Updates Teach AI section to use new strings, new styles #58027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelbyhawn
reviewed
Apr 16, 2024
| @@ -162,12 +162,14 @@ theme: responsive_full_width | |||
| %figure.col-45{style: "margin-bottom: 1rem"} | |||
| %img{src: "/images/ai/pl/101/TeachAI.png", alt: "", style: "width: 100%"} | |||
| .text-wrapper.col-50{style: "margin-bottom: 1rem"} | |||
| %p.new | |||
| =hoc_s(:new) | |||
| %h2 | |||
There was a problem hiding this comment.
Suggested change
| %h2 | |
| %h2.heading-lg |
| %h2 | ||
| =hoc_s(:teach_ai_title) | ||
| =hoc_s(:ai_promote_literacy) | ||
| %p |
There was a problem hiding this comment.
Suggested change
| %p | |
| %p.body-three |
Love it- just making those things a smidge smaller! Done:) |
kelbyhawn
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kelbyhawn I know you might want to refactor this, but this was the quickest way to utilize the .new styles without refactoring the pegasus design system stylesheet. Currently, any '.new' tag has to be nested within an action-block, which isn't the case for this page. So I took the styles and fixed the width and got it looking correct on this page in this new context.
Additionally, I know the figma has the image compensating for the much bigger height of the collective 'new' tag and the additional body lines. However, this is much harder to fix without messing with some very 'high up' margin stylings that dictate the max width of every section on the page. Considering we're fine with the 'text side' being bigger than the 'image side' higher up on the page, I elected to leave it.
Aside from that, this is just new strings and a new link url!
Before:
After:
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: