Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "[DESIGN2-104] Dropdowns - Add thick and thin label type style…" #58034

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Revert "Revert "[DESIGN2-104] Dropdowns - Add thick and thin label type style…" #58034

merged 4 commits into from
Apr 17, 2024

Conversation

levadadenys
Copy link
Collaborator

@levadadenys levadadenys commented Apr 16, 2024 •
edited

Revert "Revert "[DESIGN2-104] Dropdowns - Add thick and thin label type style…"

Before (production):
Знімок екрана 2024-04-16 о 14 11 06

After:
Знімок екрана 2024-04-16 о 14 54 02

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@levadadenys levadadenys marked this pull request as ready for review April 16, 2024 12:08
thomasoniii
thomasoniii reviewed Apr 16, 2024
View reviewed changes
apps/src/componentLibrary/dropdown/simpleDropdown/SimpleDropdown.story.tsx Outdated
)}
{args.components?.map(componentArg => (
<SimpleDropdown
key={`${componentArg.name}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this just be keyed as key={componentArg.name}? Or is it trying to force it as a string?

thomasoniii
thomasoniii approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

lfryemason
lfryemason requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@lfryemason lfryemason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to check one thing in original approval. This also modifies the margin on the new progress view. Can we also add a margin there before merging?
image

lfryemason
lfryemason approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@lfryemason lfryemason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry been a long day. I forgot that I already fixed the other instance in THIS PR. Should be ok to merge this one.

@levadadenys levadadenys merged commit a604d87 into staging Apr 17, 2024
2 checks passed
@levadadenys levadadenys deleted the dneys/design2/revert-revert-design2-104 branch April 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasoniii thomasoniii thomasoniii approved these changes

@lfryemason lfryemason lfryemason approved these changes

@sanchitmalhotra126 sanchitmalhotra126 Awaiting requested review from sanchitmalhotra126

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@levadadenys @thomasoniii @lfryemason