Convert TeacherSections component to functional component #58137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgc1194
commented
Apr 20, 2024
| coteacherInviteForPl, | ||
| studentSectionIds, | ||
| plSectionIds, | ||
| hiddenPlSectionIds, |
There was a problem hiding this comment.
I don't see this prop being used anywhere in this component. is it some legacy prop that we could get rid of, or is it missing from shouldRenderPlSections?
There was a problem hiding this comment.
Not sure about this - I'll ask in the teacher tools channel
There was a problem hiding this comment.
mgc1194
requested review from
a team and
davidsbailey
and removed request for
a team
mgc1194
changed the title
stephenliang
approved these changes
Apr 30, 2024
Nokondi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Colorado Privacy Act work the Platform team does, we add warning banners to different
Sectionscomponents.P20-815 requires adding a Warning Notification to the TeacherSections component in the TeacherHomepage.
I'd like to update the existing code and convert the class component into a functional component.
Links
Testing story
Caching
PR Checklist: