Use upstream ProxySQL 2.6.2 #58145
Merged
Use upstream ProxySQL 2.6.2 #58145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Canary test was successful today. Let's merge this after the AP Computer Science Principles "create task" deadline has passed next week. |
|
@sureshc we're clear of AP CS P, do you still want this merged in? |
sureshc
approved these changes
May 17, 2024
|
I plan to merge and deploy this tonight or at some point this weekend. This change is not blocking the Aurora 3 / MySQL 8 upgrade, but it reduces risk if there are any ProxySQL / Aurora compatibility issues with the upgrade because we'll be on the latest release and on the mainline. |
|
I like your thinking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to using upstream ProxySQL and upgrade from version 2.0.x to version 2.6.2
We previously used a code.org fork of ProxySQL in order to get this patch: sysown/proxysql#3234
That patch was applied to upstream, but we never switched back to upstream. As a result, our version of ProxySQL has been frozen at 2.0, which potentially isn't great for maintaining compatibility with the most recent aurora upgrades.
We broke the ability to provision "full stack" adhocs when we moved our fork of ProxySQL to our GitHub Organization because we haven't published a binary build, so this is a good opportunity to fix our provisioning logic. Being on mainline ProxySQL also lowers the risks with our upcoming Aurora 3 / MySQL 8 upgrade.
This is still a high risk change and should be deployed on a Friday afternoon in a limited 2nd production release so we can quickly revert, if needed.