Add gray box to My PL page with links #58182
Conversation
| @@ -23,22 +23,10 @@ | |||
| #homepage-container | |||
|
|
|||
| #workshop-links.container.main | |||
| -if can? :read, Pd::Application::ApplicationBase | |||
There was a problem hiding this comment.
These links should to more than Workshop Admins and until the work to add the Links for RPs, Facilitators and Workshop organizers is done I don't think we can remove
There was a problem hiding this comment.
Oh I see what you did. You are allows the same people to see the gray box. I don't think we want RPs, Facilitators and Workshop Organizers to see that gray box. Just internal Workshop Admins
There was a problem hiding this comment.
oh woops -- I misunderstood! I'll move this PR back to draft and update
There was a problem hiding this comment.
No issues with the links. I think you have the right list of links. What I was commenting on was the permissions. As a whole this gray box should only show for Workshop Admins (internal Code.org staff who manage workshop and application stuff). Workshop Organizers, Regional Partners, Facilitators, etc will all have access to these links right on the page. Does that help?
…rability/move-links-to-gray-box
…and workshop admins
| @@ -0,0 +1,17 @@ | |||
| - extra_links = [] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I decided to keep the conditions for which links are shown the same as they are on the homepage, but limit this box to admins and workshop admins. Likely some redundancy here, so I'm open to push back
bethanyaconnor
deleted the
bethany/pl-discoverability/move-links-to-gray-box
branch
Finishes https://codedotorg.atlassian.net/browse/ACQ-1429 and moves links from the teacher homepage to the Professional Landing page.
Admin View:
Workshop Admin view:
