Cleanup tabs and tests on My PL page #58186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnerRiley
changed the base branch from
staging
to
move-joined-pl-sections-to-my-pl-page
Base automatically changed from
move-joined-pl-sections-to-my-pl-page
to
staging
April 23, 2024 20:07
| <> | ||
| {lastWorkshopSurveyUrl && RenderLastWorkshopSurveyBanner()} | ||
| {RenderOwnedPlSections()} | ||
| {RenderEnrolledWorkshops()} |
There was a problem hiding this comment.
For facilitators, regional partners, and workshop organizers, we want to render the workshops related to that role. That data should be passed down to the client, but you might need to pull it through to this component.
Here's where that data is fetched in the controller.
There was a problem hiding this comment.
Oh you're so right, my bad! I'll fix this!
| <AddSectionDialog /> | ||
| </section> | ||
| )} | ||
| {currentTab === 'myPL' && RenderMyPlTab()} |
kelbyhawn
approved these changes
Apr 25, 2024
| <h2>My Workshops</h2> | ||
| {this.renderWorkshopsTable()} | ||
| {this.props.workshops && ( | ||
| <section> |
| <AddSectionDialog /> | ||
| </section> | ||
| )} | ||
| {currentTab === 'myPL' && RenderMyPlTab()} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up how the different My PL page tabs are rendered so it's more readable and easier to add more content in the future. Aside from adding unit tests to test that the right sections are in each tab, this PR does the following cleanup tasks:
program_manageror theworkshop_organizerpermissions, respectivelyDemos
"Facilitator Center" tab
"Instructor Center" tab
"Regional Partner Center" tab
"Workshop Organizer Center" tab
Updates the link styling in the Joined Professional Learning Sections table and the Instructor Professional Learning Sections table
Previous Joined PL Sections table:
New Joined PL Sections table:
Previous Instructor PL Sections table:
New Instructor PL Sections table:
Links
Jira ticket (general cleanup): here
Jira ticket (Workshop table on right tabs): here
Jira ticket (Workshop Feedback section on right tabs): here
Figma of page for reference: here
Testing story
Local testing and adding unit tests.