Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SageMaker Endpoint IAM Policy Syntax #58217

Merged
merged 1 commit into from Apr 24, 2024

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Apr 24, 2024

Fix forward for #58202

Testing story

Validate CloudFormation template:

suresh@CloichnaCoillte code-dot-org % bundle exec rake adhoc:validate RAILS_ENV=adhoc STACK_NAME=adhoc-fix-sagemaker-policy


Finished adhoc:environment (less than a minute)
Pending create for stack `adhoc-fix-sagemaker-policy`:
Add BrowserEventLogsStream [AWS::Logs::LogStream]
Add BrowserEventLogs [AWS::Logs::LogGroup]
Add CDOPolicy [AWS::IAM::ManagedPolicy]
Add ChefConfig [AWS::SecretsManager::Secret]
Add DBClusterIDConfig [AWS::SecretsManager::Secret]
Add DBProxyReaderEndpointConfig [AWS::SecretsManager::Secret]
Add DBProxyReportingEndpointConfig [AWS::SecretsManager::Secret]
Add DBProxyWriterEndpointConfig [AWS::SecretsManager::Secret]
Add DBWriterEndpointConfig [AWS::SecretsManager::Secret]
Add DaemonInstanceProfile [AWS::IAM::InstanceProfile]
Add DaemonRole [AWS::IAM::Role]
Add DashboardDNS [AWS::Route53::RecordSetGroup]
Add DatabaseSecretAdmin [AWS::SecretsManager::Secret]
Add DatabaseSecretReader [AWS::SecretsManager::Secret]
Add DatabaseSecretWriter [AWS::SecretsManager::Secret]
Add HourOfCodeCertificate [AWS::CertificateManager::Certificate]
Add PegasusDNS [AWS::Route53::RecordSetGroup]
Add WebServer [AWS::EC2::Instance]
Finished adhoc:validate (less than a minute)

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc merged commit 5adc0aa into staging Apr 24, 2024
1 of 2 checks passed
@sureshc sureshc deleted the infrastructure/fix-sagemaker-endpoint-policy branch April 24, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants