Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[levelbuilder] prevent creating new cs in algebra content #58245

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Apr 25, 2024

This PR is pending PM approval.

Removes the following levelbuilder features, related to the deprecation of CS in Algebra:

  • Creating new Calc levels
  • Creating new Eval levels
  • Creating new Contract Match (DSL) levels
  • Editing Calc levels, except name
  • Editing Eval levels, except name
  • Managing CS in Algebra settings while editing Play Lab levels
  • Adding Algebra blocks to Play Lab levels

Removed new level options

In addition to removing the links shown below, it is no longer to create these level types by going directly to (ex.) levels/new?type=Calc on levelbuilder
image

image

Removed Play Lab settings
image

Removed Play Lab blocks
image

Editing of Calc and Eval levels has been restricted to level name only:
image

Contract Match levels are DSL levels and can still be edited as normal.

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

Deprecation checklist: https://docs.google.com/document/d/1mEq3-lTcbSW3Oq-wJ9M3Km4A8UG6ffDzIIH1mOtEoG4/edit
Jira - https://codedotorg.atlassian.net/browse/CT-531

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv requested a review from a team April 25, 2024 16:05
@mikeharv mikeharv marked this pull request as ready for review April 25, 2024 16:06
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mikeharv mikeharv requested review from a team and Nokondi and removed request for a team April 25, 2024 16:40
@mikeharv mikeharv merged commit 7966f13 into staging Apr 27, 2024
2 checks passed
@mikeharv mikeharv deleted the mike/prevent-new-algebra-levels branch April 27, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants