Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amplitude event for Teacher Homepage visits #58247

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Apr 25, 2024

Adds a basic Amplitude event for the teacher homepage! Short and sweet :)

Screenshot 2024-04-25 at 11 59 08 AM

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review April 25, 2024 17:15
@bethanyaconnor bethanyaconnor requested review from a team and kobryan0619 and removed request for a team April 25, 2024 17:15
@bethanyaconnor
Copy link
Contributor Author

(Tagging teacher tools here as an FYI -- always happy for a review but likely won't block on it.)

Copy link
Contributor

@TurnerRiley TurnerRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just confirming we only want this for Amplitude and not also Statsig right?

@dju90
Copy link
Contributor

dju90 commented Apr 25, 2024

This logs just for signed-in teachers, is that correct?

@dju90
Copy link
Contributor

dju90 commented Apr 25, 2024

Dani mentioned that this was to help figure out how many teachers were clicking on the welcome email. This event only tracks visits to the homepage - I'm assuming that the tracking of "where did the user come from" is coming from a different source like UTM tracking? In general, this looks great and we will definitely use this on the teacher dashboard side.

@dmcavoy
Copy link
Contributor

dmcavoy commented Apr 25, 2024

Dani mentioned that this was to help figure out how many teachers were clicking on the welcome email. This event only tracks visits to the homepage - I'm assuming that the tracking of "where did the user come from" is coming from a different source like UTM tracking? In general, this looks great and we will definitely use this on the teacher dashboard side.

Yes we are using UTM to track where they came from. We need the event to be able to see that they came to the page with certain UTMs

@bethanyaconnor
Copy link
Contributor Author

Looks great! Just confirming we only want this for Amplitude and not also Statsig right?

Oh good question! I think just Amplitude for now as I don't think we've been told to start migrating any other events to Statsig (could be wrong though)

@bethanyaconnor
Copy link
Contributor Author

This logs just for signed-in teachers, is that correct?

Yep! Signed out users are redirected to the sign in page and students see the corresponding StudentHomepage component!

@bethanyaconnor bethanyaconnor merged commit 03e0bf4 into staging Apr 29, 2024
2 checks passed
@bethanyaconnor bethanyaconnor deleted the bethany/lifecycle-marketing/teacher-homepage-amplitude-event branch April 29, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants