Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceara/aitt 552 rubric UI test safari #58255

Merged
merged 6 commits into from
May 1, 2024

Conversation

cearachew
Copy link
Contributor

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Description

This reenables the safari test and adds some waiting in the UI test for the following:

  • Wait for the product tour to load before attempting to close it (the test creates a new teacher so it should show up every time)
  • Wait for the product tour to finish closing before opening the rubric FAB
  • Wait for all of the keyboard input to show up in the UI before checking for an auto-save and reloading

Links

Jira: https://codedotorg.atlassian.net/browse/AITT-552

Testing story

Ran this set of changes on Safari through saucelabs several times, all successful

Deployment strategy

Keeping an eye on the development channel to revert this change if this causes DTT failures

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@cearachew cearachew requested a review from Nokondi April 25, 2024 17:55
Copy link
Contributor

@Nokondi Nokondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job getting this working.

@cearachew cearachew merged commit 769ab66 into staging May 1, 2024
2 checks passed
@cearachew cearachew deleted the ceara/AITT-552-rubric-ui-test-safari branch May 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants