Fix Violation of and Reenable Rails/ApplicationMailer
#58264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Checks that mailers subclass `ApplicationMailer` with Rails 5.0. This is a pretty simple one; rather than inheriting from the base class to create our testing class, inherit from [the actual class used by Dashboard](https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/mailers/application_mailer.rb), which in our case is just that base class plus some extra metrics. - https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/ApplicationMailer - https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsapplicationmailer
bethanyaconnor
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty simple one; rather than inheriting from the base class to create our testing class, inherit from the actual class used by Dashboard, which in our case is just that base class plus some extra metrics.
Links
Testing story
The only thing updated here is a test file, so I'm entirely relying on tests to verify that this continues to work.