-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display message if user joins non-PL section on My PL page #58265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but someone else may want to take a look too just in case!
details={i18n.sectionsNotificationJoinSuccess({sectionName})} | ||
details={ | ||
showMessageForJoiningNonPl ? ( | ||
<SafeMarkdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
apps/i18n/common/en_us.json
Outdated
@@ -2384,6 +2384,7 @@ | |||
"sectionsNotificationJoinFull": "We couldn't add you to section {sectionId} because there are already {sectionCapacity} students in it. Please contact your teacher for help.", | |||
"sectionsNotificationJoinNotFound": "Section {sectionId} doesn't exist.", | |||
"sectionsNotificationJoinSuccess": "You joined section {sectionName}.", | |||
"sectionsNotificationJoinSuccessForNonPl": "You joined section {sectionName}. This is not a Professional Learning section so it will be visible on the [Teacher Dashboard]({teacherDashboardUrl}).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmcavoy is "Teacher Dashboard" a phrase we have shown to teachers in the past? Or is there a better name for that page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we call this the Teacher Homepage in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be out of scope, but do we want the reverse notification as well? ie if a user joins a PL section from the teacher homepage, should we direct them to the professional learning landing page?
I think that info is covered by what's shown on the Teacher Dashboard from this PR but I'm open to making one for that too! @dmcavoy thoughts? |
hm I don't see what I'm thinking of. I'm thinking of text like "You joined section {sectionName}. This is a professional learning section and will be shown on the My Professional Learning page." (slightly different than the "your sections have moved" message as that's temporary) |
Sounds good! On it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Displays a message on the My PL page if the user joins a non-PL section and displays a message on the Teacher Homepage if the user joins a PL section.
Joining section on the My PL page
For a non-PL section (shows new message):
For PL section (shows regular message):
Joining section not on the My PL page (Teacher Dashboard as an example)
For a non-PL section (shows regular message):
For PL section (shows new message):
Links
Jira ticket: here
Testing story
Local testing.