Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sequel_connection Method to Cdo::Sequel #58268

Merged
merged 7 commits into from
May 1, 2024
Merged

Extract sequel_connection Method to Cdo::Sequel #58268

merged 7 commits into from
May 1, 2024

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Apr 26, 2024

To assist #57507 extract the sequel_connect method to a module Cdo::Sequel

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc requested a review from a team as a code owner April 26, 2024 05:27
@sureshc sureshc requested a review from a team April 26, 2024 20:52
Hamms
Hamms approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; great cleanup, thanks!

@sureshc sureshc merged commit 832bf96 into staging May 1, 2024
2 checks passed
@sureshc sureshc deleted the infrastructure/extract-sequel-connection branch May 1, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sureshc @Hamms