Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove new project button for The Bad Guys #58305

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

mikeharv
Copy link
Contributor

This removes the option to make a new The Bad Guys project from the project gallery. It also removes the promo heading that has long since been disabled via DCDO. Note that we are not deprecating this project type. Existing projects will continue to work, including routes like /view, '/edit, /new, and /remix. We are simply removing the promotional links.

Before (Button Visible)
image

After (Button removed)
image

Promo heading (also removed)
image

Existing project still shows in personal projects table
image

Existing project still loads and functions
image

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv changed the title Mike/remove the bad guys project button Remove new project button for The Bad Guys Apr 29, 2024
@mikeharv mikeharv marked this pull request as ready for review April 29, 2024 16:52
@mikeharv mikeharv requested a review from a team as a code owner April 29, 2024 16:52
@mikeharv mikeharv requested a review from a team April 29, 2024 17:50
Copy link
Contributor

@ebeastlake ebeastlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹 🎉

@mikeharv mikeharv merged commit f159e4b into staging Apr 29, 2024
2 checks passed
@mikeharv mikeharv deleted the mike/remove-the-bad-guys-project-button branch April 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants