Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby-prof gem to support ARM chipset #58315

Merged
merged 2 commits into from
May 1, 2024
Merged

Update ruby-prof gem to support ARM chipset #58315

merged 2 commits into from
May 1, 2024

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Apr 29, 2024 •
edited

The current version of ruby-prof that we install (0.15.9) is failing to install on development environments that use the ARM chipset. Upgrade to the latest (1.7.0).

We only use this gem in development and test environments so this change is likely low risk.

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc requested review from simonguest, molly-moen and a team April 29, 2024 19:56
simonguest
simonguest approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@simonguest simonguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the version I've been successfully using in development.

Hamms
Hamms reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we formalize this requirement in the Gemfile itself, rather than relying on Gemfile.lock to preserve this level of specificity all on its own?

@sureshc
Copy link
Contributor Author

sureshc commented Apr 30, 2024

Could we formalize this requirement in the Gemfile itself, rather than relying on Gemfile.lock to preserve this level of specificity all on its own?

Agreed. Done!

Hamms
Hamms approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sureshc sureshc merged commit 95e5ada into staging May 1, 2024
2 checks passed
@sureshc sureshc deleted the infrastructure/upgrade-ruby-prof-gem branch May 1, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

@simonguest simonguest simonguest approved these changes

@molly-moen molly-moen molly-moen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sureshc @Hamms @simonguest @molly-moen