[ProgressV2] Add a coming soon features banner
#58316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfryemason
changed the title
coming soon features banner
lfryemason
commented
Apr 29, 2024
| @@ -23,7 +23,7 @@ module.exports = { | |||
| 'selector-pseudo-class-no-unknown': [ | |||
| true, | |||
| { | |||
| ignorePseudoClasses: ['export'], | |||
| ignorePseudoClasses: ['export', 'global'], | |||
There was a problem hiding this comment.
This is necessary in order to use the :global() selector here. Which is necessary to modify styles of a child component in an external library. The alternative is to use .scss without modules, which teacher tools is trying to move away from.
kobryan0619
reviewed
May 1, 2024
| // expect(questionText).to.not.exist; | ||
| // expect(shareMoreText).to.not.exist; | ||
| // }); | ||
| it('attempts reset and reload if error from createFeedback', async () => { |
There was a problem hiding this comment.
Thanks for adding this test!
kobryan0619
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Adds a new banner with information about what features are coming soon to the progress page.
Only opens if:
Also fixes some bugs with the ProgressFeedback Banner.
Links
https://codedotorg.atlassian.net/browse/TEACH-1030
Testing story
Added unit tests for the new component and re-enabled unit tests for the existing component after bug fixes.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: