Ceara/aitt 602 levelbuilder instructions test

[cearachew]

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Description

Adds a ruby integration test that verifies that the levelbuilder /instructions view is successfully created. There is one test that creates a simple /instructions page, and another test that creates a page with a variety of level types to display, including ones that previously broke the page.

Links

Jira ticket: https://codedotorg.atlassian.net/browse/AITT-602
Follow up to this commit: #54547

Testing story

When I undo the fix to the instructions page from this commit, the new test fails, with the fix from that commit, the test passes

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[davidsbailey]

looks great, thanks for picking this up!

[davidsbailey]

you may be able to replace all of this with something like:

@unit = create(:script, name: ..., :with_levels, lessons_count: 2, levels_count: 2)
@unit.lessons.first.script_levels.first.update!(challenge: true)
...
assert_select '.instructions_summary h1', "Lesson 1: #{@script.lessons.first.name}"

this invokes:

code-dot-org/dashboard/test/factories/factories.rb

Lines 940 to 952 in 9a47018

	trait :with_levels do
	transient do
	lessons_count {1}
	levels_count {2}
	end
	after(:create) do |script, evaluator|
	lesson_group = create :lesson_group, script: script
	evaluator.lessons_count.times do
	lesson = create :lesson, :with_activity_section, lesson_group: lesson_group
	evaluator.levels_count.times do
	level = create(:level)
	create :script_level, levels: [level], activity_section: lesson.activity_sections.first

fine to keep what you have this time, but worth looking in the factories for shortcuts next time.