Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more templates/ folders to eslint import order #58331

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

lfryemason
Copy link
Contributor

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

In order to improve code cleanliness slightly, we are rolling out an eslint rule to the entire repo that ensure .js, .jsx, .ts and .tsx files have imports automatically sorted.

We are rolling this out incrementally to prevent errors and decrease PR size. This PR removes a subset of folders from the rule exclusions.

FLUP of #57247

For PR reviewers: please double check that all comments in imports are appropriately moved with the line they are talking about.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@lfryemason lfryemason requested a review from Hamms April 30, 2024 15:27
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sourceMappingURL comment got unintentionally removed, but otherwise this LGTM!

@@ -445,4 +445,3 @@ tr.introjs-showElement > th {
z-index: 1;
opacity: 0;
}
/*# sourceMappingURL=introjs.css.map */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed these comments getting automatically removed by the linter in some of my own PRs; I'm not entirely sure why they're being removed because they don't actually appear to violate any linting rules, but I do think we want to preserve them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking in this thread to see if we can resolve this permanently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nokondi has suggested we let it be removed. I'm going to keep this PR as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we confident we don't want this comment? Note this isn't just an arbitrary comment; it's intended to enable sourcemapping for this compiled asset. This is the kind of thing where if we remove it, it won't break it an obvious way but may make it difficult down the line to diagnose something else that's broken.

Of course, it could already be broken for all I know 🙃

@lfryemason lfryemason requested a review from Hamms May 3, 2024 22:00
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for taking care of the sourceMappingURL line!

@lfryemason lfryemason merged commit c707344 into staging May 7, 2024
2 checks passed
@lfryemason lfryemason deleted the lfm/eslint-9 branch May 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants