-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music: miniplayer image & text updates #58341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion I waffled about, and otherwise +1 to everything @sanchitmalhotra126 said in his review.
beyond those, lgtm as well 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool solution!
The miniplayer will no longer show pack images for now, and will instead show a musical note image with a background radial blur, with its color provided by an optional per-pack
color
field in the library JSON, which looks like this:We also show the pack's name and artist.