Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TTL for partial registration storage #58350

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: add TTL for partial registration storage #58350

merged 1 commit into from
May 7, 2024

Conversation

stephenliang
Copy link
Member

This change adds a TTL to partial registration cache entries if the DCDO flag is enabled.

Links

Testing story

  1. With DCDO disabled, signed up for account
  2. With DCDO disabled, signed up via Google OAuth
  3. With DCDO enabled, signed up for account
  4. With DCDO enabled, signed up via Google OAuth

Deployment strategy

This will be deployed via a DCDO feature flag

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@stephenliang stephenliang marked this pull request as ready for review May 2, 2024 15:31
daynew
daynew approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@daynew daynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document somewhere when we should remove this flag code?

@stephenliang
Copy link
Member Author

Could you document somewhere when we should remove this flag code?

Created this task to followup after we are in prod and have completed the oneoff script.

@stephenliang stephenliang merged commit 5d8a5fb into staging May 7, 2024
2 checks passed
@stephenliang stephenliang deleted the stephen/email-ttl branch May 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daynew daynew daynew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephenliang @daynew