Fixing forward finish sign up analytics event #58362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in this PR broke the finish_sign_up (client side) event for effectively all cases because it did not account for the current flow nces id format. This pr removes that param entirely to get the event pushing again (both with and without the new school association flow experiment flag).
I was able to fake non-local logging to see the events showed up in statsig for all four cases:
Old flow + school selected
Old flow and no school selected
New flow + school selected
New flow and no school selected
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: