After creating a section, redirect the user to where that section is visible #58370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnerRiley
changed the title
| navigateToHref( | ||
| `/sections/new?participantType=${participantType}&loginType=${loginType}` | ||
| ); | ||
| const createSectionFromMyPl = participantType !== 'student'; |
There was a problem hiding this comment.
I'm curious ... would it be better to always redirect to the My PL page if the user created a PL section and otherwise direct to home?
Not saying we should change what's here -- just thinking out loud!
There was a problem hiding this comment.
That's what these lines are effectively doing if I'm understanding your message properly! If it's a PL section, it redirects the user to the My PL page, otherwise it redirects home. I left the URL variable as redirectToPage in case we have other pages we want to redirect to in the future!
bethanyaconnor
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a user creates/edits a section they are then redirected to the Teacher Homepage regardless of which type of section it is (i.e. PL or non-PL). This PR redirects the user to the page where they will see the section they just created/edited.
Teacher Homepage
Creating a non-PL section (should redirect back to the Teacher Homepage)
video1775467993.mp4
Creating a PL section (should redirect to the My PL page)
video2775467993.mp4
Editing a non-PL section (should redirect back to the Teacher Homepage)
video4775467993.mp4
My PL page
Creating a non-PL section (should redirect to the Teacher Homepage)
video5775467993.mp4
Creating a PL section (should redirect back to the My PL page)
video6775467993.mp4
Editing a PL section (should redirect back to the My PL page)
video3775467993.mp4
Links
Jira ticket: here
Testing story
Local testing and updating unit tests.