Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(email): do not render the 'finish signup' if email was not passed in #58382

Merged
merged 2 commits into from
May 7, 2024

Conversation

stephenliang
Copy link
Member

This change ensures that the finish signup page will not be rendered unless the email parameter is passed in for the DCDO post email flow

Links

Testing story

  1. With DCDO disabled, go to finish sign up page via email, then go to home page, and back to trying to sign up. Should go straight to finish sign up.
  2. With DCDO disabled, go to finish sign up page via Google, then go to home page, and back to trying to sign up. Should go straight to finish sign up.
  3. With DCDO enabled, go to finish sign up page via email, then go to home page, and back to trying to sign up. Should restart from the first page
  4. With DCDO enabled, go to finish sign up page via Google, then go to home page, and back to trying to sign up. Should restart from the first page

Deployment strategy

This will be deployed via a DCDO feature flag

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@stephenliang stephenliang force-pushed the stephen/partial-registration-progress branch from 7e315c1 to 0cb1ae2 Compare May 2, 2024 16:23
@stephenliang stephenliang marked this pull request as ready for review May 3, 2024 22:01
Copy link
Contributor

@carl-codeorg carl-codeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@stephenliang stephenliang merged commit 0320460 into staging May 7, 2024
2 checks passed
@stephenliang stephenliang deleted the stephen/partial-registration-progress branch May 7, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants