Fixes Zip Search Glitches

[hannahbergam]

I was able to fix the zip search lag!

The issue was that the child component was running a search in the time it took for the parent component to pass in the new 'disabled' state.

Moving the all of the zip logic (including the input box itself) down into the child component directly ties it to the search and allows the child component to manage its own disabled state. I didn't alter any of what is in the input or its label- it was a direct copy/paste.

I added a comment, moved a constant further up in the component and renamed a couple things to hopefully be more clear!

How I know this works:

I no longer see any console logs for failed zip search calls. This means we aren't calling it any extra times! I can also search a bunch of zip codes, delete digits, add them back in, and the dropdown has been populated every time. But I'd love for another developer to checkout this branch and try the same gut checks.

Screen.Recording.2024-05-02.at.2.25.24.PM.mov

(the experiment url to add is ?enableExperiments=school_association_v2)

Links

• spec:
• jira ticket: https://codedotorg.atlassian.net/browse/ACQ-1858

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[kelbyhawn]

I can check this locally! Can you remind me what flag I need to set to see it?

[kelbyhawn]

Woo hoo, exciting! 🎉

Turns out we can't test this locally unless all schools are seeded locally, so approving based on the video, but if anyone else already has all the schools seeded, feel free to look too!

[bethanyaconnor]

One thought/question/wonder but looks good!