[Labs-715][GenAI] Continue and Update buttons pushed off screen #58401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
May 3, 2024
| @@ -19,15 +19,18 @@ | |||
| .instructionsArea { | |||
| width: 30%; | |||
| height: 100%; | |||
| min-width: 200px; | |||
There was a problem hiding this comment.
Mind adding a comment similar to your PR description around why this value was chosen? Optional - also, create a sass constant for this value?
fisher-alice
reviewed
May 3, 2024
| @@ -19,15 +19,18 @@ | |||
| .instructionsArea { | |||
| width: 30%; | |||
| height: 100%; | |||
There was a problem hiding this comment.
I wonder if we should also prevent buttons from disappearing if user resizes window vertically.
There was a problem hiding this comment.
It's also included in this PR. If user resizes window vertically and height is too small - scroll for y axis will appear
There was a problem hiding this comment.
2024-05-06.14.41.27.mov
There was a problem hiding this comment.
Nice! Thanks for the demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Labs-715][GenAI] Continue and Update buttons pushed off screen
Fixed the issue by setting the
min-widthto every column and addingoverflow: auto, so that in case the screen width is too small - user will be able to just scroll horizontally. 200px is a value got from visual comparison (screen collapses when columns width is smaller than 196.7px, we use x8 factor for design system, so used the closes x8 factor here, which is 200px )Before:
After:
2024-05-03.19.05.04.mov
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: