Add Workshop Organizer Center on My Professional Learning page #58402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnerRiley
commented
May 3, 2024
Comment on lines
-1969
to
-1971
| "plSectionsRegionalPartnerWorkshopTitle": "Workshop Dashboard", | ||
| "plSectionsRegionalPartnerWorkshopDesc": "Manage upcoming, in progress, and past workshops.", | ||
| "plSectionsRegionalPartnerWorkshopButton": "View workshop dashboard", |
There was a problem hiding this comment.
Since this component and the Regional Partner Resources section use the same strings, I updated the names to be more universal. Since these strings were just created I feel like changing the names won't affect the translation timeline too much but I'm open to pushback if I should just use the existing names even though they'll say "RegionalPartner" in them
There was a problem hiding this comment.
They might not have even made it to Crowdin yet and this page in general isn't high priority for translation. So I think this makes sense!
bethanyaconnor
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Workshop Organizer Center section to the Workshop Organizer tab on the My Professional Learning page.
Links
Jira ticket: here
Figma: here
Testing story
Local testing and update unit tests.