Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates annotations to use observations when evidence is empty and to scroll to first line of evidence. #58408

Merged
merged 1 commit into from
May 10, 2024
Merged

Updates annotations to use observations when evidence is empty and to scroll to first line of evidence. #58408

merged 1 commit into from
May 10, 2024

Conversation

wilkie
Copy link
Contributor

@wilkie wilkie commented May 3, 2024 •
edited

This adds both the scrolling to the first line of evidence and rendering observations as evidence when the AI fails to provide evidence, which hopefully will not happen too often but happens in practice.

Links

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@wilkie wilkie marked this pull request as ready for review May 8, 2024 19:45
@wilkie wilkie requested a review from a team as a code owner May 8, 2024 19:45
@wilkie wilkie requested review from davidsbailey and Nokondi and removed request for a team and davidsbailey May 8, 2024 19:46
davidsbailey
davidsbailey approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice unit tests! in the absence of end-to-end testing, a screen capture would be nice to show this in action.

@wilkie
Copy link
Contributor Author

wilkie commented May 10, 2024

aitt-scroll-to-line-demo.mp4

@wilkie wilkie merged commit ba8c28c into staging May 10, 2024
2 checks passed
@wilkie wilkie deleted the aitt-updates-to-evidence-to-use-observations branch May 10, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@Nokondi Nokondi Awaiting requested review from Nokondi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wilkie @davidsbailey