Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling to prevent text from being pushed down from top of banner #58412

Merged
merged 2 commits into from
May 7, 2024

Conversation

dju90
Copy link
Contributor

@dju90 dju90 commented May 4, 2024

Links

Testing story

Testing locally
Before
banner_before

After
banner_after

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dju90
Copy link
Contributor Author

dju90 commented May 7, 2024

Also tested on:
Chrome
banner_after_chrome

Firefox
banner_after_firefox

Co-authored-by: Liam Frye-Mason <liam.fryemason@code.org>
@dju90 dju90 requested a review from lfryemason May 7, 2024 19:55
@dju90 dju90 merged commit defab03 into staging May 7, 2024
2 checks passed
@dju90 dju90 deleted the p-banner-small-screens branch May 7, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants