Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Music Lab skinny banners to code.org #58419

Merged
merged 2 commits into from
May 6, 2024

Conversation

kelbyhawn
Copy link
Contributor

@kelbyhawn kelbyhawn commented May 6, 2024

Adds Music Lab skinny banners to the following pages in preparation for the launch in a couple weeks:

These will show up when the music-lab-launch-2024 DCDO flag is set to true.

Links

Jira tickets: ACQ-1674ACQ-1675
Figma mock: here

Testing story

Tested locally, and tested DCDO flag locally to make sure it works


code.org/teach

Desktop

code.org/student/elementary

Elementary

code.org/student/middle-high

MidHigh

Reponsive

Tablet Mobile
Tablet Mobile

RTL

localhost code org_3000_teach(Code org - 1366x768)

@kelbyhawn kelbyhawn requested a review from a team May 6, 2024 20:16
Copy link
Contributor

@TurnerRiley TurnerRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kelbyhawn kelbyhawn merged commit d9a643b into staging May 6, 2024
2 checks passed
@kelbyhawn kelbyhawn deleted the add-music-lab-skinny-banners branch May 6, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants