[Google Blockly] Register custom procedure blocks in old labs #58425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the Sprite Lab migration, we implemented custom versions of the new shareable procedures. When we were ready to migrate Minecraft later, we simply needed to register the blocks. (https://github.com/code-dot-org/code-dot-org/pull/55993/files#diff-972ff80c7f8bd964897bbfa702b7e753dd5e99a06b72a5664a259dd6a6be33a7)
Now we can do the same for Maze, Artist (aka Turtle), and Play Lab (aka Studio) to help prepare them for migration. I tested these changes with a variety of Maze levels and saw the expected improvements, detailed below. I didn't specifically test Artist or Play Lab yet, but
registerCustomProcedureBlocks
doesn't do anything if we're in the CDO Blockly Wrapper, so there's really no risk with this change.As a review, here are some ways you can tell that we're using our custom blocks:
Course 4.16.2
Course 4.16.2
Course E.14.3
Course E.14.4
Links
Jira -https://codedotorg.atlassian.net/browse/CT-558
Follow-up work
Support functions with parameters. :(
PR Checklist: