Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Blockly] skip creating dropdown field arrow for uneditable blocks #58446

Merged
merged 1 commit into from
May 7, 2024

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented May 7, 2024

Yesterday I noticed some minor UI differences in dropdown fields when they are on gray "stone" (undeletable) blocks. On CDO Blockly, if a stone block has an editable dropdown field, it will have a teal arrow and a yellow background. I brought this up with @code-dot-org/product-design on Slack and Mark had the following requests:

  1. Remove the dropdown arrow for stone blocks that can't be edited
  2. Change the dropdown arrow to dark gray (match the block) for stone blocks that can be edited
  3. Match the pattern of the teal blocks by keeping the direction box light gray for both kinds of stone blocks

Mark's mock-up (using CDO Blockly blocks)
Screenshot 2024-05-07 at 11 15 31 AM

This PR addresses the first request. Fortunately, the 2nd and 3rd requests already match Google Blockly as we weren't doing any of the recoloring yet.

With changes (Google Blockly blocks)

image (197)

Links

Slack thread - https://codedotorg.slack.com/archives/C0SUN2SSF/p1715022245209579
Jira - https://codedotorg.atlassian.net/browse/CT-557

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv requested a review from a team May 7, 2024 18:21
@mikeharv mikeharv merged commit 70d5058 into staging May 7, 2024
2 checks passed
@mikeharv mikeharv deleted the mike/stone-block-ui-changes branch May 7, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants