Add amplitude event to code.org/music and update activity links #58450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
reviewed
May 7, 2024
| @@ -86,3 +86,5 @@ theme: responsive_full_width | |||
| =hoc_s(:dance_afe_disclaimer) | |||
|
|
|||
| = view :swiper_page_music_lab | |||
|
|
|||
| = view :analytics_event_log_helper, event_name: AnalyticsConstants::MUSIC_PAGE_VISITED_EVENT | |||
There was a problem hiding this comment.
Is the analytics event log helper automatically sending all events to both?
There was a problem hiding this comment.
I just double checked- that .js file would require a refactor to send Statsig events by default
There was a problem hiding this comment.
We can pair on it this PM if you want! (Also... if Statsig isn't a requirement here then please ignore me)
There was a problem hiding this comment.
I don't know how that Statsig console message originally showed up, and I can't get it to show up again, weird! 🤔
@dmcavoy do you want Statsig set up for Pegasus pages too?
There was a problem hiding this comment.
Not right now. Lets keep this just amplitude
hannahbergam
reviewed
May 7, 2024
hannahbergam
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Amplitude (and Statsig) events to https://code.org/music, and updates the existing urls to the activity to include a
/resetat the end in a few places.Links
Jira ticket: ACQ-1869
Testing story
Local testing