[Gen ai] Log level path instead of level id on Amplitude/Statsig #58459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
reviewed
May 7, 2024
apps/src/aichat/redux/aichatRedux.ts
Outdated
| dispatch | ||
| ); | ||
| } | ||
| ); | ||
|
|
||
| const getLevelPath = (progress: ProgressState) => { |
There was a problem hiding this comment.
Is there a reason not to just grab the URL (something like window.location.pathname)?
There was a problem hiding this comment.
Oh cool! I don't think so. I'll go ahead and use window.location.pathname instead. Thanks!
There was a problem hiding this comment.
FYI - when I added level url to Dance AI analytics, I added currentScriptLevelUrl. #55531
But now I see I could've used window.location.pathname instead. Wonder if I should remove this seemingly unnecessary property.
There was a problem hiding this comment.
Yeah that seems redundant to me, but I could be missing something :)
bencodeorg
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logs the level path instead of level id when sending an event to Amplitude/Statsig. This was requested by @samantha-code .
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: