Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odd spacing on My PL page #58483

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix odd spacing on My PL page #58483

merged 2 commits into from
May 9, 2024

Conversation

TurnerRiley
Copy link
Contributor

@TurnerRiley TurnerRiley commented May 8, 2024

In the "Joined PL Sections" section of the My PL page, if the user isn't in any sections then the spacing looks odd and leaves little room before the "Recommended for you" section below. So, this PR adds conditional formatting if the user isn't enrolled in any PL sections.

Previous "Joined PL Sections" with no sections (odd spacing)

old my pl no section

Previous "Joined PL Sections" with sections (no change)

old my pl with section

New "Joined PL Sections" with no sections (fixed spacing)

New joined pl no section

New "Joined PL Sections" with sections (no change)

New joined pl with section

Links

Jira ticket: here

Testing story

Local testing.

@TurnerRiley TurnerRiley requested a review from a team May 8, 2024 23:22
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I could go either way on adding this kind of logic in vs. outside of the render, so happy to approve as-is:)

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!!

Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo, thanks for doing this! 🎉

@TurnerRiley
Copy link
Contributor Author

Makes sense to me! I could go either way on adding this kind of logic in vs. outside of the render, so happy to approve as-is:)

Oh true, actually for consistency's-sake within the file, I'll move it to outside of the render!

@TurnerRiley TurnerRiley merged commit 6b5a540 into staging May 9, 2024
2 checks passed
@TurnerRiley TurnerRiley deleted the fix-my-pl-spacing branch May 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants