Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skinny banner and logo section to /districts page #58530

Merged
merged 2 commits into from
May 10, 2024

Conversation

TurnerRiley
Copy link
Contributor

@TurnerRiley TurnerRiley commented May 10, 2024

Adds skinny banner and logo section to /districts page.

Skinny banner (links to /educate/districts/partners)

skinny banner

Logo section

meet districts section

Responsive:
responsive

RTL:
RTL

Links

Jira ticket: items 2 and 3 from the ticket
Figma: here

Testing story

Local testing.

Follow-up work

Item 4 from the ticket.

@TurnerRiley TurnerRiley requested a review from a team as a code owner May 10, 2024 19:00
@TurnerRiley TurnerRiley requested a review from a team May 10, 2024 19:01
Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I left a suggestion for the logos section, and can you double check that the logos work responsively? Using that .logos-wrapper class should automatically do it.

Meet the Districts in our District Program
%p.centered
Over 100 school districts have already joined!
.logos.flex-container.justify-center.align-items-start.wrap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the .logos-wrapper class here; it should negate the need to add any custom styles, but you will need to set a max-width on the images (see docs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and added screenshots!

Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! 🎉

@TurnerRiley TurnerRiley merged commit b48dac2 into staging May 10, 2024
2 checks passed
@TurnerRiley TurnerRiley deleted the update-districts-page-sections branch May 10, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants