Add more folder to import/order lint rule #58622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
approved these changes
May 16, 2024
| import './styles/Weblab2View.css'; | ||
|
|
||
| import {Config} from './Config'; | ||
| import './styles/Weblab2View.css'; // eslint-disable-line import/order |
There was a problem hiding this comment.
can you also add a comment explaining why this is necessary, and which specifically of the other imports in the file we need this to before?
# Conflicts: # apps/src/types/redux.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve code cleanliness slightly, we are rolling out an eslint rule to the entire repo that ensure .js, .jsx, .ts and .tsx files have imports automatically sorted.
We are rolling this out incrementally to prevent errors and decrease PR size. This PR removes a subset of folders from the rule exclusions.
FLUP of #57247
For PR reviewers: please double check that all comments in imports are appropriately moved with the line they are talking about.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: