Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design2-111] DSCO - Buttons - Add gray color, add fill to secondary and tertiary types #58636

Merged
merged 8 commits into from
May 21, 2024

Conversation

levadadenys
Copy link
Collaborator

@levadadenys levadadenys commented May 15, 2024

[Design2-111] DSCO - Buttons - Add grey color, add fill to secondary and tertiary types

  • added background fill color to secondary and tertiary black and white buttons
  • added gray secondary button
  • deprecated purple secondary button

Before:
Знімок екрана 2024-05-15 о 14 33 02

After:
Знімок екрана 2024-05-16 о 14 57 27
Знімок екрана 2024-05-16 о 14 57 34

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@levadadenys levadadenys changed the title [Design2-111] DSCO - Buttons - Add grey color, add fill to secondary and tertiary types [Design2-111] DSCO - Buttons - Add gray color, add fill to secondary and tertiary types May 16, 2024
@levadadenys levadadenys requested review from sanchitmalhotra126, a team and cearachew and removed request for a team May 16, 2024 12:11
@levadadenys levadadenys marked this pull request as ready for review May 16, 2024 12:12
Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@levadadenys
Copy link
Collaborator Author

Deprecated Secondary Purple Button instead of removing it. Reason - we already use secondary purple button in couple places, that's why drone builds was failing. Planning to warn people about it and then remove it in a separate PR.

@levadadenys levadadenys merged commit bd2411d into staging May 21, 2024
2 checks passed
@levadadenys levadadenys deleted the denys/design2/design2-108-2 branch May 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants