Require US state during account signup and on update #58697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanzojr
changed the title
stephenliang
approved these changes
May 16, 2024
juanmanzojr
changed the title
daynew
approved these changes
May 16, 2024
juanmanzojr
added a commit
that referenced
this pull request
May 16, 2024
This reverts commit 2028cd0.
juanmanzojr
added a commit
that referenced
this pull request
May 17, 2024
juanmanzojr
added a commit
that referenced
this pull request
May 17, 2024
* Add us_state validation back and adding unit tests * WIP * Tests for country code inclusion in state modal * Add country code field patch params to test country persists --------- Co-authored-by: Dayne <dayne@code.org>
juanmanzojr
added a commit
that referenced
this pull request
May 22, 2024
* Add us_state validation back and adding unit tests * WIP * Tests for country code inclusion in state modal * Add country code field patch params to test country persists * Add check if change will happen to us_state in validation * us_state new value validation * Comment for clarity * Require US state during account signup and on update (#58697) * Add us_state validation back and adding unit tests * WIP * Tests for country code inclusion in state modal * Add country code field patch params to test country persists --------- Co-authored-by: Dayne <dayne@code.org> * Comment for clarity * Comment for test clarity * Update state validation for robustness * Add test coverage for us_state validation * Change username to name in test us_state validation --------- Co-authored-by: Dayne <dayne@code.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes validation for the
us_statein the user model to happen on create and on update.We were allowing students to sign up without providing a
us_statedue to the changes made in this PR.Students were allowed to continue without a US state as the validation was only happening when the
us_statewas present on an on create or on update.This PR also adds the
country_codefield to the State modal in order to make sure this field is also being set for validation purposes.After using State modal to set state
Finish Sign up if us_state missing
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: