Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotd flaky test tracking reminders #58811

Merged
merged 6 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aws/ci_build
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ def main

if CDO.test_system?
DevelopersTopic.set_dtt 'no (robo-DTT failed)'
ChatClient.log "*** Before you manually re-run a test, please ensure that the team who owns that test is actively tracking de-flaking. ***", color: 'yellow'
msg = "*** <@#{DevelopersTopic.dotd}> Please update the " \
"<https://docs.google.com/spreadsheets/d/1DD6ebHM-2fsiMxxYCzhJYd1DzA69Z20qrCItaER9vto|Flaky Test Tracker>. " \
"See instructions in the tracker for more info. ***"
ChatClient.log msg, color: 'yellow'
end
end

Expand Down
6 changes: 5 additions & 1 deletion bin/cron/update_dotd
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ def main

# Set the new developers room topic
new_topic = current_topic.sub(/^.+?;/, "DOTD: @#{primary_dotd_user};")
Slack.update_topic('developers', new_topic) unless new_topic == current_topic
unless new_topic == current_topic
Slack.update_topic('developers', new_topic)

Slack.remind(Slack.user_id(DevelopersTopic.dotd), Time.now.to_i + 3600, msg)
lfryemason marked this conversation as resolved.
Show resolved Hide resolved
end
end

main