Add share and remix option to Python Lab #58820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
May 21, 2024
| @@ -6,6 +6,6 @@ | |||
| = render partial: 'levels/editors/fields/checkboxes', locals: {f: f, field_name: :disable_sharing, description: "Disable sharing"} | |||
| %p If set, this level cannot be shared or saved to galleries even if it's free play. | |||
|
|
|||
| = render partial: 'levels/editors/fields/checkboxes', locals: {f: f, field_name: :hide_share_and_remix, description: "Hide Share and Remix buttons in header"} if (@level.uses_droplet?) || @level.is_a?(Blockly) || @level.is_a?(Weblab) ||@level.is_a?(Javalab) | |||
| = render partial: 'levels/editors/fields/checkboxes', locals: {f: f, field_name: :hide_share_and_remix, description: "Hide Share and Remix buttons in header"} if (@level.uses_droplet?) || @level.is_a?(Blockly) || @level.is_a?(Weblab) ||@level.is_a?(Javalab) ||@level.uses_lab2? | |||
There was a problem hiding this comment.
ultra nit: space after the || in a couple places?
breville
approved these changes
May 21, 2024
sanchitmalhotra126
approved these changes
May 21, 2024
| @@ -51,7 +51,7 @@ const Lab2ShareDialogWrapper: React.FunctionComponent< | |||
| return null; | |||
| } | |||
|
|
|||
| if (appType === 'music') { | |||
| if (appType === 'music' || appType === 'pythonlab') { | |||
There was a problem hiding this comment.
minor/later: would it be worth storing a list of lab2 labs that support the new share dialog in lab2's constants.ts instead of needing to update this condition whenever we enable this for a new lab?
There was a problem hiding this comment.
good call, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to add share and remix buttons to Python Lab. Thanks to lab2 this was a pretty straightforward change of plugging in some puzzle pieces.
Now level 2 in Python Lab all the things has share and remix buttons, and you can create a new project with
/projects/pythonlab/new.I used the Music Lab share modal for this, it's easy to swap if we want to use the old one.
Links
Testing story
Tested locally. You can share and remix from the level, and create new projects and share/remix them.
Follow-up work
I found a bug where if you remix from a level and then open the projects page, your new project doesn't have a type. This is due to a quirk of how we populate that page. I filed a bug here
PR Checklist: