Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Forsyth-Edwards Notation" hole #719

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Add "Forsyth-Edwards Notation" hole #719

merged 2 commits into from
Aug 11, 2022

Conversation

btnlq
Copy link
Contributor

@btnlq btnlq commented Aug 11, 2022 •
edited
Loading

Implements #645.

Arg:

1n1Rkb1r/p4ppp/4q3/4p1B1/4P3/8/PPP2PPP/2K5 b k - 1 17

Output:

　♞　♖♚♝　♜
♟　　　　♟♟♟
　　　　♛　　　
　　　　♟　♗　
　　　　♙　　　
　　　　　　　　
♙♙♙　　♙♙♙
　　♔　　　　　

@JRaspass
Copy link
Collaborator

You might want to remove the Closes #645 from the commit as we probably want the issue to remain open while the hole is experimental as it links to the issue and people can discuss implementation concerns there.

JRaspass
JRaspass reviewed Aug 11, 2022
View reviewed changes
config/holes.toml Outdated
@@ -735,6 +735,38 @@ preamble = '''
for example <b>15</b> should print <b>FizzBuzz</b>.
'''

['Forsyth-Edwards Notation']
category = 'Transform'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use Gaming as we lack many holes in that category, what do you think?

@JRaspass JRaspass merged commit c891523 into code-golf:master Aug 11, 2022
@btnlq btnlq deleted the fen branch August 11, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRaspass JRaspass JRaspass left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btnlq @JRaspass