Add the ability to override and access clock related methods in ROSIntegrationGameInstance #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added virtual to enable dynamic dispatch for OnWorldTickStart so that it could be overridden - Made ClockTopic protected so it is accessible by children
Merge origin master changes
harveybia
changed the title
|
Thanks for the PR! Congratz on having your first one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the need to make my own game instance and override the behavior of clock topic published by the
ROSIntegrationGameInstance.Changes:
OnWorldTickStartto make it possible for children to override itClockTopicfrom private to protected to make it accessible by childrenResults:
Tested on UE 4.25.3 and no behavior change is introduced. I created my own GameInstance which inherits the
ROSIntegrationGameInstanceand I was able to change the clock behavior (manually advance sim time when needed instead of sync with UE frame advance).