fix(core): upload issue without source if file not linked

code-pushup · Feb 9, 2024 · 2923dbd · 2923dbd
1 parent 973a648
commit 2923dbd
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
     "node": ">=18.16"
   },
   "dependencies": {
-    "@code-pushup/portal-client": "^0.4.1",
+    "@code-pushup/portal-client": "^0.5.0",
     "@isaacs/cliui": "^8.0.2",
     "@poppinss/cliui": "^6.3.0",
     "@swc/helpers": "0.5.3",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -5,7 +5,7 @@
   "dependencies": {
     "@code-pushup/models": "*",
     "@code-pushup/utils": "*",
-    "@code-pushup/portal-client": "^0.4.1",
+    "@code-pushup/portal-client": "^0.5.0",
     "chalk": "^5.3.0"
   },
   "type": "commonjs",

diff --git a/packages/core/src/lib/implementation/json-to-gql.ts b/packages/core/src/lib/implementation/json-to-gql.ts
@@ -69,12 +69,14 @@ export function issuesToGql(issues: Issue[] | undefined) {
     issues?.map(issue => ({
       message: issue.message,
       severity: transformSeverity(issue.severity),
-      sourceEndColumn: issue.source?.position?.endColumn,
-      sourceEndLine: issue.source?.position?.endLine,
-      sourceFilePath: issue.source?.file,
-      sourceStartColumn: issue.source?.position?.startColumn,
-      sourceStartLine: issue.source?.position?.startLine,
-      sourceType: IssueSourceType.SourceCode,
+      ...(issue.source?.file && {
+        sourceType: IssueSourceType.SourceCode,
+        sourceFilePath: issue.source.file,
+        sourceStartLine: issue.source.position?.startLine,
+        sourceStartColumn: issue.source.position?.startColumn,
+        sourceEndLine: issue.source.position?.endLine,
+        sourceEndColumn: issue.source.position?.endColumn,
+      }),
     })) ?? []
   );
 }

diff --git a/packages/models/package.json b/packages/models/package.json
@@ -4,6 +4,6 @@
   "license": "MIT",
   "dependencies": {
     "zod": "^3.22.1",
-    "@code-pushup/portal-client": "^0.4.1"
+    "@code-pushup/portal-client": "^0.5.0"
   }
 }