refactor(plugin-lighthouse): update lighthouse and adopt tests (#685)

code-pushup · Jun 12, 2024 · 4f1a8b0 · 4f1a8b0
1 parent 64d7ae8
commit 4f1a8b0
Show file tree

Hide file tree

Showing 15 changed files with 115 additions and 219 deletions.
diff --git a/code-pushup.config.ts b/code-pushup.config.ts
@@ -104,12 +104,6 @@ const config: CoreConfig = {
       title: 'SEO',
       refs: [lighthouseGroupRef('seo')],
     },
-    {
-      slug: 'pwa',
-      title: 'PWA',
-      isBinary: true,
-      refs: [lighthouseGroupRef('pwa')],
-    },
     {
       slug: 'bug-prevention',
       title: 'Bug prevention',

diff --git a/e2e/cli-e2e/tests/__snapshots__/collect.e2e.test.ts.snap b/e2e/cli-e2e/tests/__snapshots__/collect.e2e.test.ts.snap
@@ -1727,19 +1727,6 @@ exports[`CLI collect > should run Lighthouse plugin that runs lighthouse CLI and
       "slug": "seo",
       "title": "SEO",
     },
-    {
-      "isBinary": true,
-      "refs": [
-        {
-          "plugin": "lighthouse",
-          "slug": "pwa",
-          "type": "group",
-          "weight": 1,
-        },
-      ],
-      "slug": "pwa",
-      "title": "PWA",
-    },
   ],
   "packageName": "@code-pushup/core",
   "plugins": [
@@ -1750,18 +1737,13 @@ exports[`CLI collect > should run Lighthouse plugin that runs lighthouse CLI and
           "slug": "largest-contentful-paint",
           "title": "Largest Contentful Paint",
         },
-        {
-          "description": "Service worker is the technology that enables your app to use many Progressive Web App features, such as offline, add to homescreen, and push notifications. With proper service worker and manifest implementations, browsers can proactively prompt users to add your app to their homescreen, which can lead to higher engagement. [Learn more about manifest installability requirements](https://developer.chrome.com/docs/lighthouse/pwa/installable-manifest/).",
-          "slug": "installable-manifest",
-          "title": "Web app manifest and service worker meet the installability requirements",
-        },
         {
           "description": "Deprecated APIs will eventually be removed from the browser. [Learn more about deprecated APIs](https://developer.chrome.com/docs/lighthouse/best-practices/deprecations/).",
           "slug": "deprecations",
           "title": "Avoids deprecated APIs",
         },
         {
-          "description": "Each ARIA \`role\` supports a specific subset of \`aria-*\` attributes. Mismatching these invalidates the \`aria-*\` attributes. [Learn how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.8/aria-allowed-attr).",
+          "description": "Each ARIA \`role\` supports a specific subset of \`aria-*\` attributes. Mismatching these invalidates the \`aria-*\` attributes. [Learn how to match ARIA attributes to their roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-attr).",
           "slug": "aria-allowed-attr",
           "title": "\`[aria-*]\` attributes match their roles",
         },
@@ -1814,17 +1796,6 @@ exports[`CLI collect > should run Lighthouse plugin that runs lighthouse CLI and
           "slug": "seo",
           "title": "SEO",
         },
-        {
-          "description": "These checks validate the aspects of a Progressive Web App. [Learn what makes a good Progressive Web App](https://web.dev/articles/pwa-checklist).",
-          "refs": [
-            {
-              "slug": "installable-manifest",
-              "weight": 2,
-            },
-          ],
-          "slug": "pwa",
-          "title": "PWA",
-        },
       ],
       "icon": "lighthouse",
       "slug": "lighthouse",

diff --git a/examples/react-todos-app/code-pushup.config.js b/examples/react-todos-app/code-pushup.config.js
@@ -38,8 +38,6 @@ export default {
         'deprecations',
         // seo category
         'hreflang',
-        // pwa category
-        'installable-manifest',
       ],
       chromeFlags: DEFAULT_FLAGS.concat(['--headless']),
     }),
@@ -65,12 +63,6 @@ export default {
       title: 'SEO',
       refs: [lighthouseGroupRef('seo')],
     },
-    {
-      slug: 'pwa',
-      title: 'PWA',
-      isBinary: true,
-      refs: [lighthouseGroupRef('pwa')],
-    },
     {
       slug: 'code-coverage',
       title: 'Code coverage',