Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-lighthouse): update lighthouse and adopt tests #685

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented May 28, 2024

Lighthouse v12 received significant changes see release notes.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 models 🧩 lighthouse-plugin 🛠️ tooling labels May 28, 2024
Copy link

nx-cloud bot commented May 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8494239. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

# Conflicts:
#	packages/plugin-lighthouse/package.json
@BioPhoton BioPhoton self-assigned this May 28, 2024
# Conflicts:
#	packages/models/src/lib/implementation/schemas.ts
#	packages/plugin-lighthouse/package.json
@github-actions github-actions bot removed 📖 Project documentation improvements or additions to the project documentation 🧩 models labels Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 619d806 with source commit 8a1c834.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 71 🟡 88 ↓ −17.2
Accessibility 🟢 98 🟢 100 ↓ −1.7
SEO 🟡 85 🟡 86 ↓ −1
Updates 🟡 89 🟡 89 ↑ +0.2
Code coverage 🟡 89 🟡 89 ↓ −0.1
Best Practices 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 94 🟢 94
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 1 group improved, 👎 4 groups regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 71 🟡 88 ↓ −17.2
Lighthouse Accessibility 🟢 98 🟢 100 ↓ −1.7
Lighthouse SEO 🟡 85 🟡 86 ↓ −1
JS Packages NPM outdated dependencies 🟡 89 🟡 89 ↑ +0.2
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 8 audits regressed, 10 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Avoid large layout shifts 🟩 15 layout shifts found 🟥 15 layout shifts found  −∞ %
Lighthouse Background and foreground colors have a sufficient contrast ratio 🟥 0 🟩 0  −∞ %
Lighthouse Total Blocking Time 🟥 1,360 ms 🟩 130 ms ↑ +946 %
Lighthouse Max Potential First Input Delay 🟥 520 ms 🟨 220 ms ↑ +135 %
Lighthouse Cumulative Layout Shift 🟩 0.006 🟨 0.147  −∞ %
Lighthouse Largest Contentful Paint 🟨 2.8 s 🟨 2.9 s ↓ −6 %
Lighthouse Speed Index 🟩 2.6 s 🟩 1.5 s ↑ +80 %
JS Packages Outdated NPM dev dependencies. 🟨 56 outdated package versions (26 major, 23 minor, 1 preminor, 5 patch, 1 prerelease) 🟨 57 outdated package versions (27 major, 24 minor, 5 patch, 1 prerelease) ↓ −2 %
Lighthouse Time to Interactive 🟩 3.0 s 🟩 2.6 s ↑ +13 %
Lighthouse First Contentful Paint 🟩 1.0 s 🟩 1.2 s ↓ −16 %
Code coverage Branch coverage 🟨 83 % 🟨 83 %  +0 %
Code coverage Function coverage 🟩 91 % 🟩 91 %  +0 %
Code coverage Line coverage 🟩 91 % 🟩 91 %  +0 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 431 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Minimizes main-thread work 🟥 4.2 s 🟥 2.8 s ↑ +49 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse Properly size images 🟥 Potential savings of 239 KiB 🟥 Potential savings of 240 KiB ↓ −88 %
Lighthouse Metrics 🟩 2985 🟩 2647 ↑ +13 %
Lighthouse JavaScript execution time 🟩 0.1 s 🟩 0.1 s ↓ −35 %
Lighthouse First Meaningful Paint 🟩 1.1 s 🟩 1.2 s ↓ −2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 10 ms ↑ +78 %
Lighthouse Server Backend Latencies 🟩 20 ms 🟩 20 ms ↓ −32 %
Lighthouse Initial server response time was short 🟩 Root document took 0 ms 🟩 Root document took 10 ms ↓ −57 %

482 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review June 12, 2024 13:51
matejchalk
matejchalk previously approved these changes Jun 12, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

packages/plugin-lighthouse/src/lib/runner/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton merged commit 4f1a8b0 into main Jun 12, 2024
16 checks passed
@BioPhoton BioPhoton deleted the update-lighthouse branch June 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants