Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-coverage,plugin-js-packages): always include issues array, even if empty #679

Merged
merged 5 commits into from
May 23, 2024

Conversation

matejchalk
Copy link
Collaborator

  • To differentiate audits which may produce issues but didn't find any from audits which never produce issues (useful for display purposes), made sure Code coverage and JS Packages always output issues array.
  • Fixed (hopefully 🤞) NPM publish in release workflow, nx release uses a different environment variable for the NPM access token (according to docs).

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🦾 CI/CD continuous integration and deployment 🧩 coverage-plugin 🧩 js-packages-plugin Plugin for audit and outdated dependencies labels May 23, 2024
Copy link

nx-cloud bot commented May 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e927409. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented May 23, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 0922c4f with source commit a047ba9.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Accessibility 🟢 98 🟢 100 ↓ −1.8
Performance 🟡 87 🟡 89 ↓ −1.7
Code coverage 🟡 70 🟡 70 ↓ +0
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 94 🟢 94
Updates 🟡 70 🟡 70
Custom checks 🟡 67 🟡 67

🗃️ Groups

👎 3 groups regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Accessibility 🟢 98 🟢 100 ↓ −1.8
Lighthouse Performance 🟡 87 🟡 89 ↓ −1.7
Code coverage Code coverage metrics 🟡 70 🟡 70 ↓ +0

18 other groups are unchanged.

🛡️ Audits

👍 2 audits improved, 👎 5 audits regressed, 12 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Background and foreground colors have a sufficient contrast ratio 🟥 0 🟩 0  −∞ %
Lighthouse Max Potential First Input Delay 🟥 270 ms 🟨 180 ms ↑ +48 %
Lighthouse Total Blocking Time 🟩 160 ms 🟩 100 ms ↑ +64 %
Lighthouse Time to Interactive 🟩 1.4 s 🟩 2.6 s ↓ −45 %
Lighthouse Cumulative Layout Shift 🟨 0.148 🟨 0.147  −∞ %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 66 % 🟨 66 %  +0 %
Lighthouse Metrics 🟩 1438 🟩 2593 ↓ −45 %
Lighthouse Minimizes main-thread work 🟥 2.4 s 🟥 2.5 s ↓ −4 %
Lighthouse JavaScript execution time 🟩 0.1 s 🟩 0.0 s ↑ +233 %
Lighthouse Speed Index 🟩 1.1 s 🟩 1.2 s ↓ −3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Largest Contentful Paint 🟨 2.8 s 🟨 2.8 s ↓ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 0 ms ↑ +700 %
Lighthouse Server Backend Latencies 🟩 10 ms 🟩 20 ms ↓ −41 %
Lighthouse First Contentful Paint 🟩 1.1 s 🟩 1.1 s ↓ +0 %
Lighthouse First Meaningful Paint 🟩 1.1 s 🟩 1.1 s ↓ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 0 ms 🟩 Root document took 0 ms ↑ +100 %

504 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review May 23, 2024 10:34
@matejchalk matejchalk requested a review from Tlacenka as a code owner May 23, 2024 10:34
@matejchalk matejchalk removed the 📖 Project documentation improvements or additions to the project documentation label May 23, 2024
vmasek
vmasek previously approved these changes May 23, 2024
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label May 23, 2024
@matejchalk matejchalk merged commit 87b5983 into main May 23, 2024
19 checks passed
@matejchalk matejchalk deleted the explicit-issues branch May 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD continuous integration and deployment 🧩 coverage-plugin 🧩 js-packages-plugin Plugin for audit and outdated dependencies 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants