Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): include audit table in portal upload #680

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

matejchalk
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 core 🛠️ tooling labels May 23, 2024
Copy link

nx-cloud bot commented May 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 44dfebf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@matejchalk matejchalk removed 📖 Project documentation improvements or additions to the project documentation 🛠️ tooling labels May 23, 2024
@matejchalk matejchalk marked this pull request as ready for review May 23, 2024 12:47
@matejchalk matejchalk requested a review from Tlacenka as a code owner May 23, 2024 12:47
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 722eb9e with source commit 76b9772.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟢 90 🟡 89 ↑ +1.6
Code coverage 🟡 70 🟡 70 ↑ +0
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 94 🟢 94
Updates 🟡 70 🟡 70
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟢 90 🟡 89 ↑ +1.6
Code coverage Code coverage metrics 🟡 70 🟡 70 ↑ +0

19 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Max Potential First Input Delay 🟥 260 ms 🟨 190 ms ↑ +33 %
Lighthouse Largest Contentful Paint 🟨 2.6 s 🟨 2.9 s ↓ −10 %
Lighthouse First Contentful Paint 🟩 1.1 s 🟩 1.3 s ↓ −9 %
Lighthouse Total Blocking Time 🟩 100 ms 🟩 70 ms ↑ +44 %
Code coverage Function coverage 🟨 64 % 🟨 64 %  +0 %
Code coverage Line coverage 🟨 66 % 🟨 66 %  +0 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Lighthouse Minimizes main-thread work 🟩 2.0 s 🟩 1.8 s ↑ +11 %
Lighthouse Properly size images 🟥 Potential savings of 240 KiB 🟥 Potential savings of 240 KiB ↓ −12 %
Lighthouse Metrics 🟩 2487 🟩 2606 ↓ −5 %
Lighthouse Time to Interactive 🟩 2.5 s 🟩 2.6 s ↓ −5 %
Lighthouse First Meaningful Paint 🟩 1.1 s 🟩 1.3 s ↓ −9 %
Lighthouse Speed Index 🟩 1.7 s 🟩 1.6 s ↑ +6 %
Lighthouse Server Backend Latencies 🟩 30 ms 🟩 10 ms ↑ +145 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↑ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↑ +0 %
Lighthouse JavaScript execution time 🟩 0.1 s 🟩 0.1 s ↓ −16 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 10 ms ↓ −57 %
Lighthouse Initial server response time was short 🟩 Root document took 10 ms 🟩 Root document took 0 ms ↑ +150 %

504 other audits are unchanged.

@matejchalk matejchalk merged commit 2b4f3e1 into main May 23, 2024
20 checks passed
@matejchalk matejchalk deleted the tables-upload branch May 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants