Send more data to segment #1817
Conversation
guillaumerose
commented
Jan 5, 2021
guillaumerose
commented
- Use track and identify calls
- Track all commands (success = true|false)
- Track the duration of each command
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guillaumerose The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } | ||
| return err | ||
| startTime := time.Now() | ||
| err := input(cmd, args) |
There was a problem hiding this comment.
The initial agreement which we had with PM about tracking only the errors not all the commands, did we get an ack for this implementation?
There was a problem hiding this comment.
I didn't ask (yet). I am more worried that we will have 0 data with the current implementation.
Can we add this new data @sspeiche ?
- If the user consent to it, we track all commands: duration, success and eventual error.
There was a problem hiding this comment.
There wasn't a limitation on tracking just errors, so this is fine. We just have limitations on tracking personally identifiable information like IP address.
Identify is for adding/updating user properties. Track is for individual action.
guillaumerose
force-pushed
the
segment1
branch
from
a5f3885
to
58daae5
Compare
|
/lgtm |
