[cony] Weather app step3 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conyconydev
commented
Dec 3, 2019
conyconydev
commented
- Weather app step3 진행하였습니다.
godrm
reviewed
Dec 3, 2019
|
|
||
| ///jsonData -> foundationData | ||
| static func parseJSONData() -> Array<Dictionary<String,String>>? { | ||
| let json = getContestsFromURL(url: "http://public.codesquad.kr/jk/weatherapp/customcell.json") |
There was a problem hiding this comment.
JSONParser도 문자열을 하드코딩하지 않고 매개변수나 외부에서 의존성을 넣어주도록 만들었으면 유연한 구조가 됐을 것 같네요. 참고하세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.