fix: Fixes #22 and #27 by adding custom signin page and show password with shadcn #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreyas0924 is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
siinghd
requested changes
Feb 2, 2024
| redirect: false, | ||
| }); | ||
|
|
||
| if (!res?.error) { |
There was a problem hiding this comment.
I think it would be also better to add an alert or something to notify the user about the error.
There was a problem hiding this comment.
Added Sonner toast..
siinghd
requested changes
Feb 2, 2024
| @@ -26,6 +28,13 @@ const Signin = () => { | |||
|
|
|||
| if (!res?.error) { | |||
| router.push('/'); | |||
| } else { | |||
| toast('Error Signing in', { | |||
There was a problem hiding this comment.
Can't this error be more specific? res?.error probably. Might be good to display the returned error insted of static message.
There was a problem hiding this comment.
Yeah should address this in a follow up, merging for now as a v1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 and #27
custom.login.mp4